Algorithms/JavaAlgorithms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleanup PerfectSquare and its tests (#4992)

Browse Source
This commit is contained in:
Piotr Idzik 2024-01-04 11:56:48 +01:00 committed by GitHub
parent 092ac5795b
commit 1ea95ffa92
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/main/java/com/thealgorithms/maths/PerfectSquare.java
View File

@ -3,14 +3,8 @@ package com.thealgorithms.maths;
/** /**
* https://en.wikipedia.org/wiki/Perfect_square * https://en.wikipedia.org/wiki/Perfect_square
*/ */
public class PerfectSquare { public final class PerfectSquare {
private PerfectSquare() {
public static void main(String[] args) {
assert !isPerfectSquare(-1);
assert !isPerfectSquare(3);
assert !isPerfectSquare(5);
assert isPerfectSquare(9);
assert isPerfectSquare(100);
} }
/** /**
@ -20,8 +14,8 @@ public class PerfectSquare {
* @return <tt>true</tt> if {@code number} is perfect square, otherwise * @return <tt>true</tt> if {@code number} is perfect square, otherwise
* <tt>false</tt> * <tt>false</tt>
*/ */
public static boolean isPerfectSquare(int number) { public static boolean isPerfectSquare(final int number) {
int sqrt = (int) Math.sqrt(number); final int sqrt = (int) Math.sqrt(number);
return sqrt * sqrt == number; return sqrt * sqrt == number;
} }
} }

41
src/test/java/com/thealgorithms/maths/PerfectSquareTest.java
View File

@ -1,38 +1,21 @@
package com.thealgorithms.maths; package com.thealgorithms.maths;
import static org.junit.jupiter.api.Assertions.*; import java.util.stream.Stream;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
public class PerfectSquareTest { public class PerfectSquareTest {
@ParameterizedTest
@Test @ValueSource(ints = {0, 1, 2 * 2, 3 * 3, 4 * 4, 5 * 5, 6 * 6, 7 * 7, 8 * 8, 9 * 9, 10 * 10, 11 * 11, 123 * 123})
public void TestPerfectSquareifiscorrect() { void positiveTest(final int number) {
// Valid Partition Assertions.assertTrue(PerfectSquare.isPerfectSquare(number));
int number = 9;
boolean result = PerfectSquare.isPerfectSquare(number);
assertTrue(result);
} }
@Test @ParameterizedTest
public void TestPerfectSquareifisnotcorrect() { @ValueSource(ints = {-1, -2, -3, -4, -5, -100, 2, 3, 5, 6, 7, 8, 10, 11, 12, 13, 15, 17, 99, 101, 257, 999, 1001})
// Invalid Partition 1 void negativeTest(final int number) {
int number = 3; Assertions.assertFalse(PerfectSquare.isPerfectSquare(number));
boolean result = PerfectSquare.isPerfectSquare(number);
assertFalse(result);
}
@Test
public void TestPerfectSquareifisNegativeNumber() {
// Invalid Partition 2
int number = -10;
boolean result = PerfectSquare.isPerfectSquare(number);
assertFalse(result);
} }
} }