From 364e27b5a0bafa564363ce9fb907a11a00d7bf14 Mon Sep 17 00:00:00 2001 From: Mani Manasa Mylavarapu Date: Sat, 21 Oct 2017 23:22:07 +0530 Subject: [PATCH] moved the class from others papckage to default. and implemeted the following review comments. Remove the package Please provide a description for checkIfANumberIsAmstrongOrNot function Provide a description for what actually is an Armstrong number at the top along with an example fixes #96 --- Armstrong.java | 47 +++++++++++++++++++++++++++++++++++++++++++ Others/Armstrong.java | 27 ++++++++++++++++--------- 2 files changed, 65 insertions(+), 9 deletions(-) create mode 100644 Armstrong.java diff --git a/Armstrong.java b/Armstrong.java new file mode 100644 index 00000000..9267d9ea --- /dev/null +++ b/Armstrong.java @@ -0,0 +1,47 @@ +import java.util.Scanner; + +/** + * A utility to check if a given number is armstrong or not. Armstrong number is + * a number that is equal to the sum of cubes of its digits for example 0, 1, + * 153, 370, 371, 407 etc. For example 153 = 1^3 + 5^3 +3^3 + * + * @author mani manasa mylavarapu + * + */ +public class Armstrong { + public static void main(String[] args) { + Scanner scan = new Scanner(System.in); + System.out.println("please enter the number"); + int n = scan.nextInt(); + boolean isArmstrong = checkIfANumberIsAmstrongOrNot(n); + if (isArmstrong) { + System.out.println("the number is armstrong"); + } else { + System.out.println("the number is not armstrong"); + } + } + + /** + * Checks whether a given number is an armstrong number or not. Armstrong + * number is a number that is equal to the sum of cubes of its digits for + * example 0, 1, 153, 370, 371, 407 etc. + * + * @param number + * @return boolean + */ + public static boolean checkIfANumberIsAmstrongOrNot(int number) { + int remainder, sum = 0, temp = 0; + temp = number; + while (number > 0) { + remainder = number % 10; + sum = sum + (remainder * remainder * remainder); + number = number / 10; + } + if (sum == temp) { + return true; + } else { + return false; + } + + } +} \ No newline at end of file diff --git a/Others/Armstrong.java b/Others/Armstrong.java index 7cbc0550..fe12e2fb 100644 --- a/Others/Armstrong.java +++ b/Others/Armstrong.java @@ -1,10 +1,14 @@ package Others; import java.util.Scanner; + /** - * To check if a given number is armstrong or not. + * A utility to check if a given number is armstrong or not. Armstrong number is + * a number that is equal to the sum of cubes of its digits for example 0, 1, + * 153, 370, 371, 407 etc. For example 153 = 1^3 + 5^3 +3^3 + * * @author mani manasa mylavarapu - * + * */ public class Armstrong { public static void main(String[] args) { @@ -12,19 +16,24 @@ public class Armstrong { System.out.println("please enter the number"); int n = scan.nextInt(); boolean isArmstrong = checkIfANumberIsAmstrongOrNot(n); - if(isArmstrong) - { + if (isArmstrong) { System.out.println("the number is armstrong"); - } - else - { + } else { System.out.println("the number is not armstrong"); } } + /** + * Checks whether a given number is an armstrong number or not. Armstrong + * number is a number that is equal to the sum of cubes of its digits for + * example 0, 1, 153, 370, 371, 407 etc. + * + * @param number + * @return boolean + */ public static boolean checkIfANumberIsAmstrongOrNot(int number) { - int remainder, sum = 0,temp=0; - temp=number; + int remainder, sum = 0, temp = 0; + temp = number; while (number > 0) { remainder = number % 10; sum = sum + (remainder * remainder * remainder);