Merge pull request #1247 from BanQiaoGeXia/Development

Optimize method flip in SortUtils #1246

src/main/java/com/sorts/CycleSort.java

@@ -15,7 +15,7 @@ public class CycleSort {
         int count = 0;
 
         // Traverse array and put the elements on their respective right places
-        for (int i = 0; i < n - 2; i++) {
+        for (int i = 0; i < n - 1; i++) {
 
             // Initialize item as the starting point
             T item = arr[i];

src/main/java/com/sorts/SortUtils.java

@@ -38,7 +38,7 @@ final class SortUtils {
      * @param right is a right flip border of the array
      */
     static <T extends Comparable<T>> void flip(T[] array, int left, int right) {
-        while (left <= right) {
+        while (left < right) {
             swap(array, left++, right--);
         }
     }

src/test/java/com/dataStructures/StackTest.java

@@ -36,7 +36,7 @@ class StackTest {
         myStack.push(30);
         myStack.push(40);
 
-        Assertions.assertEquals(40, myStack.peek());
+        Assertions.assertEquals(40, (int) myStack.peek());
     }
 
     @Test
@@ -57,7 +57,7 @@ class StackTest {
         myStack.push(40);
         myStack.push(50);
 
-        Assertions.assertEquals(50, myStack.pop());
+        Assertions.assertEquals(50, (int) myStack.pop());
 
     }
 

src/test/java/com/sorts/CycleSortTest.java

@@ -30,5 +30,8 @@ class CycleSortTest {
         String[] sortedStr = new String[]{"Alan", "David", "Dennis", "Edward", "Ken", "Linus", "Robert"};
         Assertions.assertArrayEquals(sortedStr, cycleSort.sort(unsortedStr));
 
+        Integer[] unsortedShortInt = new Integer[]{29, 11};
+        Integer[] sortedShortInt = new Integer[]{11, 29};
+        Assertions.assertArrayEquals(sortedShortInt, cycleSort.sort(unsortedShortInt));
     }
 }