Algorithms/JavaAlgorithms
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added function and fixed bug in PerfectCube.java (#3655)

Browse Source 
* Added another function to PerfectCube.java

Added another function to PerfectCube.java and fixed a testing mistake in line number 9

* Created PerfectCubeTest.java

Created PerfectCubeTest.java

* fixed PerfectCubeTest.java

* Fixed bug in PerfectCube.java

Fixed bug in PerfectCube.java in isPerfectCube() function for negative numbers. Now It gives the correct output for perfect negative numbers.

* removed main() in PerfectCube.java
This commit is contained in:
Taranjeet Singh Kalsi 2022-10-29 11:57:17 +05:30 committed by GitHub
parent 5ab1b6c319
commit 957f633c93
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 46 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/main/java/com/thealgorithms/maths/PerfectCube.java
View File

@ -5,15 +5,6 @@ package com.thealgorithms.maths;
*/
public class PerfectCube {
public static void main(String[] args) {
assert !isPerfectCube(-1);
assert isPerfectCube(0);
assert isPerfectCube(1);
assert !isPerfectCube(4);
assert isPerfectCube(8);
assert isPerfectCube(27);
}
/**
* Check if a number is perfect cube or not
*
@ -22,7 +13,20 @@ public class PerfectCube {
* {@code false}
*/
public static boolean isPerfectCube(int number) {
number = Math.abs(number); // converting negative number to positive number
int a = (int) Math.pow(number, 1.0 / 3);
return a * a * a == number;
}
/**
* Check if a number is perfect cube or not by using Math.cbrt function
*
* @param number number to check
* @return {@code true} if {@code number} is perfect cube, otherwise
* {@code false}
*/
public static boolean isPerfectCubeMathCbrt(int number) {
double cubeRoot = Math.cbrt(number);
return cubeRoot == (int) cubeRoot;
}
}

33
src/test/java/com/thealgorithms/maths/PerfectCubeTest.java Normal file
View File

@ -0,0 +1,33 @@
package com.thealgorithms.maths;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
class PerfectCubeTest {
@Test
public void perfectCube() {
Assertions.assertTrue(PerfectCube.isPerfectCube(-27));
Assertions.assertTrue(PerfectCube.isPerfectCubeMathCbrt(-27));
Assertions.assertTrue(PerfectCube.isPerfectCube(-1));
Assertions.assertTrue(PerfectCube.isPerfectCubeMathCbrt(-1));
Assertions.assertTrue(PerfectCube.isPerfectCube(0));
Assertions.assertTrue(PerfectCube.isPerfectCubeMathCbrt(0));
Assertions.assertTrue(PerfectCube.isPerfectCube(1));
Assertions.assertTrue(PerfectCube.isPerfectCubeMathCbrt(1));
Assertions.assertTrue(PerfectCube.isPerfectCube(8));
Assertions.assertTrue(PerfectCube.isPerfectCubeMathCbrt(8));
Assertions.assertTrue(PerfectCube.isPerfectCube(27));
Assertions.assertTrue(PerfectCube.isPerfectCubeMathCbrt(27));
Assertions.assertFalse(PerfectCube.isPerfectCube(-9));
Assertions.assertFalse(PerfectCube.isPerfectCubeMathCbrt(-9));
Assertions.assertFalse(PerfectCube.isPerfectCube(2));
Assertions.assertFalse(PerfectCube.isPerfectCubeMathCbrt(2));
Assertions.assertFalse(PerfectCube.isPerfectCube(4));
Assertions.assertFalse(PerfectCube.isPerfectCubeMathCbrt(4));
Assertions.assertFalse(PerfectCube.isPerfectCube(30));
Assertions.assertFalse(PerfectCube.isPerfectCubeMathCbrt(30));
}
}