Alex K
91101ec424
Refactoring and code improving for OddEvenSort ( #5242 )
...
* Refactoring and code improving for OddEvenSort, changing it according to SortAlgorithm approach, also applying SortUtils
* Fix checkstyle
* Remove redundant main, remove redundant tests.
---------
Co-authored-by: alx <alx@alx.com>
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
2024-06-20 08:26:09 +02:00
Alex K
a9db8428b2
Refactoring BinaryInsertionSort according to common SortAlgorithm approach ( #5239 )
...
* Refactoring BinaryInsertionSort according to common SortAlgorithm approach
* Formatting has been fixed
* Refactoring tests for BinaryInsertionSort according to SortingAlgorithmTest
* Removing redundant tests and improving variable readability
---------
Co-authored-by: alx <alx@alx.com>
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
2024-06-19 18:57:54 +02:00
Samuel Facchinello
74e51990c1
style: enable InvalidJavadocPosition in checkstyle ( #5237 )
...
enable style InvalidJavadocPosition
Co-authored-by: Samuel Facchinello <samuel.facchinello@piksel.com>
2024-06-18 19:34:22 +02:00
Samuel Facchinello
9973b8efc8
refactor: redesign StringMatchFiniteAutomata ( #5222 )
...
* refactor
* add test
* fix clang
* fix pmd
* remove main method
* refactor searchPattern with private class
* fix checkstyle
* Update src/main/java/com/thealgorithms/others/StringMatchFiniteAutomata.java
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
* Update src/main/java/com/thealgorithms/others/StringMatchFiniteAutomata.java
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
* Update src/main/java/com/thealgorithms/others/StringMatchFiniteAutomata.java
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
* fix clang
* tests: add more test cases
---------
Co-authored-by: Samuel Facchinello <samuel.facchinello@piksel.com>
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
2024-06-17 20:55:20 +00:00
Samuel Facchinello
cdb3affdd9
style: enable AvoidNestedBlocks in checkstyle ( #5228 )
...
* enable style AvoidNestedBlocks
* refactor after enable style AvoidNestedBlocks
* fix clang
* fix checkstyle
* fix pmd
---------
Co-authored-by: Samuel Facchinello <samuel.facchinello@piksel.com>
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
2024-06-14 16:57:30 +02:00
Samuel Facchinello
87b17e0571
style: enable NeedBraces in checkstyle ( #5227 )
...
* enable style NeedBraces
* style: enable NeedBraces in checkstyle
---------
Co-authored-by: Samuel Facchinello <samuel.facchinello@piksel.com>
2024-06-13 21:00:16 +02:00
Samuel Facchinello
51fcc66345
refactor: redesign LetterCombinationsOfPhoneNumber ( #5221 )
...
* Refactor
* fix clang
* fix clang
* fix clang tests
* fix pattern
* add test case null
* Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
* Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
* Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
* Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
* Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
* Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
* Update src/test/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumberTest.java
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
* rename MAP_OF_CHARS to KEYPAD
* fix clang
* remove main
* add tests
* feat: throw for wrong inputs
* change keypad to list
* Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
* Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
* Update src/main/java/com/thealgorithms/strings/LetterCombinationsOfPhoneNumber.java
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
* fix with number 1 (empty value), and add tests
* style: avoid concatenation while populating `KEYPAD`
* change to assertEquals
---------
Co-authored-by: Samuel Facchinello <samuel.facchinello@piksel.com>
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
2024-06-13 19:40:12 +02:00
Piotr Idzik
31db1af345
style: include SUI_CONTAINS_BEFORE_ADD ( #5216 )
2024-06-13 17:27:49 +00:00
Samuel Facchinello
a2af09cdfb
style: enable ParenPad in checkstyle ( #5226 )
...
* enable ParenPad
* style: enable ParenPad in checkstyle
---------
Co-authored-by: Samuel Facchinello <samuel.facchinello@piksel.com>
2024-06-13 19:25:43 +02:00
Piotr Idzik
f8698674b3
style: include IM_BAD_CHECK_FOR_ODD ( #5213 )
2024-06-13 10:07:14 +05:30
StarDxxx
a81fb32e6c
style: enable TypeName ( #5214 )
...
* style: enable `TypeName` in checkstyle
* style: enable `TypeName` in checkstyle
* Update directory
* style: use proper formatting
---------
Co-authored-by: StarDxxx <StarDxxx@users.noreply.github.com>
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
2024-06-08 13:37:20 +02:00
StarDxxx
be38886d43
style: enable OperatorWrap in checkstyle ( #5212 )
2024-06-08 09:36:42 +02:00
Piotr Idzik
41efe7fbbc
style: include DMC_DUBIOUS_MAP_COLLECTION ( #5207 )
2024-06-07 23:29:53 +05:30
Piotr Idzik
b315b7d578
style: include WMI_WRONG_MAP_ITERATOR ( #5206 )
2024-06-06 00:22:12 +05:30
Piotr Idzik
440f3ce18b
style: include MAC_MANUAL_ARRAY_COPY ( #5199 )
2024-06-04 21:02:38 +00:00
Piotr Idzik
493942e319
style: include IT_NO_SUCH_ELEMENT ( #5200 )
2024-06-05 02:24:38 +05:30
Piotr Idzik
2e387fe54e
style: include IMC_IMMATURE_CLASS_VAR_NAME ( #5197 )
2024-06-01 21:36:12 +00:00
Piotr Idzik
5e4db7baf1
style: include SS_SHOULD_BE_STATIC ( #5198 )
2024-06-02 02:54:11 +05:30
Godwill Christopher
c42b1c940c
style: enable ParameterName in CheckStyle. ( #5196 )
...
* Enabled: ParameterName in CheckStyle.
* Refactored to fix bug caused by selfAssignment of variables in VectorCrossproduct class
2024-05-31 22:01:11 +02:00
Alex K
2568b96784
Adding class for generating all subsequences from a given List ( #5194 )
...
* Adding class for generating all subsequences from a given List
* Fix test data format
* Fix braces wrong placement
* Fix "Utility classes should not have a public or default constructor."
* Fix checkstyle " Class Subsequence should be declared as final."
* Renaming class Subsequence to SubsequenceFinder. Refactored test to Parametrized test. Fixed input parameter as final.
* Fix formatting
* Fix formatting
* Fix formatting
* Fix import ordering
* Renaming method generate all.
Renaming test method.
Adding duplication test.
Renaming TestData to TestCase.
* Fix formatting
* style: add assertion to avoid potential infinite loop
---------
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
2024-05-30 18:43:15 +00:00
S. Utkarsh
a6e873deef
style: enable MemberName in checkstyle ( #5193 )
...
* style: enable MemberName in checkstyle
* style: simply uncomment `MemberName`
---------
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
2024-05-29 20:44:14 +00:00
Piotr Idzik
d2bfb100b2
style: include LII_LIST_INDEXED_ITERATING ( #5190 )
2024-05-28 19:06:47 +00:00
Piotr Idzik
2cda944643
style: include ENMI_EQUALS_ON_ENUM ( #5189 )
2024-05-28 19:03:52 +00:00
S. Utkarsh
25d711c5d8
style: enable LocalVariableName in CheckStyle ( #5191 )
...
* style: enable LocalVariableName in checkstyle
* Removed minor bug
* Resolved Method Name Bug
* Changed names according to suggestions
2024-05-28 20:29:28 +02:00
Piotr Idzik
92887a10c2
style: include NAB_NEEDLESS_BOXING_PARSE ( #5184 )
2024-05-28 06:47:51 +00:00
Piotr Idzik
70c1d97ab1
style: include SPP_TOSTRING_ON_STRING ( #5183 )
2024-05-28 02:37:20 +05:30
Godwill Christopher
295e7436b1
style: enable MethodName in CheckStyle ( #5182 )
...
enabled: MethodName in CheckStyle
2024-05-27 09:06:06 +02:00
Piotr Idzik
ea4dc15a24
style: do not suppress try ( #5167 )
2024-05-27 03:02:36 +05:30
Bama Charan Chhandogi
37c2a96fe2
style: enable MissingSwitchDefault in checkstyle ( #5179 )
...
* Update directory
* Update directory
* Update directory
* Update directory
* add switch default
---------
Co-authored-by: BamaCharanChhandogi <BamaCharanChhandogi@users.noreply.github.com>
2024-05-26 17:28:00 +05:30
vaibhav9t1
9eaa2bb756
style: enable MultipleVariableDeclarations in checkstyle ( #5175 )
...
Co-authored-by: vaibhav <vaibhav.waghmare@techprescient.com>
2024-05-25 20:18:27 +02:00
vaibhav9t1
44ce6e7b0d
style: enable StaticVariableName in checkstyle ( #5173 )
...
* style: enable StaticVariableName in checkstyle
* Refractored: enable StaticVariableName in checkstyle
* style: mark more variables as `final`
---------
Co-authored-by: vaibhav <vaibhav.waghmare@techprescient.com>
Co-authored-by: vil02 <vil02@o2.pl>
2024-05-25 14:09:14 +00:00
Godwill Christopher
160742104d
Enabled LocalFinalVariableName in Checkstyle ( #5172 )
2024-05-24 16:38:37 +05:30
Piotr Idzik
8be8b953ab
style: do not suppress this-escape ( #5166 )
2024-05-20 16:09:23 +00:00
Piotr Idzik
8466219685
style: do not suppress serial ( #5168 )
2024-05-20 20:39:31 +05:30
Piotr Idzik
bf9d0ed66a
fix: handle constant inputs in `LongestIncreasingSubsequence::findLISLen' ( #5160 )
...
fix: handle constant inputs in `LongestIncreasingSubsequence::findLISLen`
2024-05-17 15:24:22 +05:30
Godwill Christopher
0f42e995a4
style: enabled InnerAssignment in checkstyle ( #5162 )
...
* style: enabled InnerAssignment in checkstyle
* Refactor code formatting in KnapsackMemoization.java and UnionFind.java
* style: remove redundant blank line
* style: mark `includeCurrentItem` and `excludeCurrentItem` as `final`
* style: remove `KnapsackMemoization` from `pmd-exclude.properties`
* style: use `final`
---------
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
2024-05-16 16:46:03 +00:00
Godwill Christopher
bbef89c885
refactor: simplify logic of Point::equals in KDTree ( #5158 )
2024-05-12 12:37:14 +02:00
Godwill Christopher
5703be5953
style: enable EqualsHashCode in checkstyle ( #5157 )
2024-05-12 11:38:07 +02:00
Piotr Idzik
319d5143cc
refactor: cleanup DudeneyNumber ( #5156 )
2024-05-12 14:35:33 +05:30
Piotr Idzik
cf6c87c35c
style: make SubsetCount a proper utility ( #5153 )
2024-05-11 14:36:17 +00:00
Godwill Christopher
bbe4a025df
style: enable FinalClass in checkstyle ( #5154 )
2024-05-11 08:50:05 +02:00
Piotr Idzik
52f15b2b08
style: include RV_RETURN_VALUE_IGNORED ( #5152 )
2024-05-09 15:23:22 +00:00
Piotr Idzik
27c0978851
style: include VA_FORMAT_STRING_USES_NEWLINE ( #5151 )
2024-05-09 17:21:04 +02:00
Piotr Idzik
7bff82f175
style: include LEST_LOST_EXCEPTION_STACK_TRACE ( #5150 )
2024-05-09 15:15:36 +00:00
Piotr Idzik
ee6924a2a0
style: include PATH_TRAVERSAL_IN ( #5148 )
2024-05-09 20:04:57 +05:30
Piotr Idzik
d2ddec55e5
style: include NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION ( #5149 )
...
* style: use `assertFalse` and `assertTrue`
* style: include `NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION`
2024-05-08 22:41:46 +05:30
Piotr Idzik
d3bb691f59
style: enable HideUtilityClassConstructor in checkstyle ( #5147 )
2024-05-08 09:58:29 +03:00
Piotr Idzik
bfb27eeb59
style: enable ArrayTypeStyle in checkstyle ( #5145 )
2024-05-06 22:49:52 +03:00
Piotr Idzik
414835db11
style: enable AvoidStarImport in checkstyle ( #5141 )
2024-05-05 20:48:56 +02:00
Piotr Idzik
dc47e0aa42
style: include ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD ( #5129 )
2024-05-05 18:39:26 +00:00
