From 3c7b505b5bcaac8ad8492b8fe5d4a7137803a950 Mon Sep 17 00:00:00 2001
From: M M Arif <mmarif@noreply.codeberg.org>
Date: Thu, 29 Oct 2020 13:52:40 +0100
Subject: [PATCH] Fix view recycling issue (#742)

Fix view issue

Co-authored-by: M M Arif <mmarif@swatian.com>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/742
---
 .../org/mian/gitnex/adapters/AssigneesListAdapter.java    | 8 +++++++-
 .../java/org/mian/gitnex/adapters/LabelsListAdapter.java  | 6 +++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/org/mian/gitnex/adapters/AssigneesListAdapter.java b/app/src/main/java/org/mian/gitnex/adapters/AssigneesListAdapter.java
index d80fa661..fcc823af 100644
--- a/app/src/main/java/org/mian/gitnex/adapters/AssigneesListAdapter.java
+++ b/app/src/main/java/org/mian/gitnex/adapters/AssigneesListAdapter.java
@@ -50,12 +50,13 @@ public class AssigneesListAdapter extends RecyclerView.Adapter<AssigneesListAdap
 		private ImageView assigneesAvatar;
 
 		private AssigneesViewHolder(View itemView) {
+
 			super(itemView);
+			this.setIsRecyclable(false);
 
 			assigneesSelection = itemView.findViewById(R.id.assigneesSelection);
 			assigneesName = itemView.findViewById(R.id.assigneesName);
 			assigneesAvatar = itemView.findViewById(R.id.assigneesAvatar);
-
 		}
 	}
 
@@ -73,9 +74,11 @@ public class AssigneesListAdapter extends RecyclerView.Adapter<AssigneesListAdap
 		Collaborators currentItem = assigneesList.get(position);
 
 		if(currentItem.getFull_name().equals("")) {
+
 			holder.assigneesName.setText(currentItem.getLogin());
 		}
 		else {
+
 			holder.assigneesName.setText(currentItem.getFull_name());
 		}
 		PicassoService
@@ -90,6 +93,7 @@ public class AssigneesListAdapter extends RecyclerView.Adapter<AssigneesListAdap
 		}
 
 		currentAssignees = new ArrayList<>(new LinkedHashSet<>(currentAssignees));
+
 		for(int i = 0; i < currentAssignees.size(); i++) {
 
 			if(currentAssignees.contains(currentItem.getLogin())) {
@@ -98,6 +102,7 @@ public class AssigneesListAdapter extends RecyclerView.Adapter<AssigneesListAdap
 				assigneesStrings.add(currentAssignees.get(i));
 			}
 		}
+
 		assigneesListener.assigneesInterface(assigneesStrings);
 
 		holder.assigneesSelection.setOnCheckedChangeListener((buttonView, isChecked) -> {
@@ -119,6 +124,7 @@ public class AssigneesListAdapter extends RecyclerView.Adapter<AssigneesListAdap
 
 	@Override
 	public int getItemCount() {
+
 		return assigneesList.size();
 	}
 
diff --git a/app/src/main/java/org/mian/gitnex/adapters/LabelsListAdapter.java b/app/src/main/java/org/mian/gitnex/adapters/LabelsListAdapter.java
index be152b12..4a01cb16 100644
--- a/app/src/main/java/org/mian/gitnex/adapters/LabelsListAdapter.java
+++ b/app/src/main/java/org/mian/gitnex/adapters/LabelsListAdapter.java
@@ -48,12 +48,13 @@ public class LabelsListAdapter extends RecyclerView.Adapter<LabelsListAdapter.La
 		private ImageView labelColor;
 
 		private LabelsViewHolder(View itemView) {
+
 			super(itemView);
+			this.setIsRecyclable(false);
 
 			labelSelection = itemView.findViewById(R.id.labelSelection);
 			labelText = itemView.findViewById(R.id.labelText);
 			labelColor = itemView.findViewById(R.id.labelColor);
-
 		}
 	}
 
@@ -85,6 +86,7 @@ public class LabelsListAdapter extends RecyclerView.Adapter<LabelsListAdapter.La
 		}
 
 		currentLabelsIds = new ArrayList<>(new LinkedHashSet<>(currentLabelsIds));
+
 		for(int i = 0; i < currentLabelsIds.size(); i++) {
 
 			if(currentLabelsIds.contains(currentItem.getId())) {
@@ -93,6 +95,7 @@ public class LabelsListAdapter extends RecyclerView.Adapter<LabelsListAdapter.La
 				labelsIds.add(currentLabelsIds.get(i));
 			}
 		}
+
 		labelsListener.labelsIdsInterface(labelsIds);
 
 		holder.labelSelection.setOnCheckedChangeListener((buttonView, isChecked) -> {
@@ -117,6 +120,7 @@ public class LabelsListAdapter extends RecyclerView.Adapter<LabelsListAdapter.La
 
 	@Override
 	public int getItemCount() {
+
 		return labels.size();
 	}