Fix Clang compiler warnings (-Winconsistent-missing-destructor-override)

Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>

cmake/compiler-flags.cmake

@@ -298,7 +298,6 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
   add_compiler_flags(10 "-Wno-global-constructors")
   add_compiler_flags(10 "-Wno-gnu-zero-variadic-macro-arguments")
   add_compiler_flags(10 "-Wno-implicit-int-conversion")
-  add_compiler_flags(10 "-Wno-inconsistent-missing-destructor-override")
   add_compiler_flags(10 "-Wno-non-virtual-dtor")
   add_compiler_flags(10 "-Wno-padded")
   add_compiler_flags(10 "-Wno-pessimizing-move")

src/oatpp/core/async/worker/IOEventWorker.hpp

@@ -104,7 +104,7 @@ public:
   /**
    * Virtual destructor.
    */
-  ~IOEventWorker();
+  ~IOEventWorker() override;
 
   /**
    * Push list of tasks to worker.
@@ -158,7 +158,7 @@ public:
   /**
    * Virtual destructor.
    */
-  ~IOEventWorkerForeman();
+  ~IOEventWorkerForeman() override;
 
   /**
    * Push list of tasks to worker.

src/oatpp/core/data/stream/BufferStream.hpp

@@ -55,7 +55,7 @@ public:
   /**
    * Virtual destructor.
    */
-  ~BufferOutputStream();
+  ~BufferOutputStream() override;
 
   /**
    * Write `count` of bytes to stream.

src/oatpp/core/data/stream/FileStream.hpp

@@ -72,7 +72,7 @@ public:
   /**
    * Virtual destructor.
    */
-  ~FileInputStream();
+  ~FileInputStream() override;
 
   /**
    * Get file.
@@ -160,7 +160,7 @@ public:
   /**
    * Virtual destructor.
    */
-  ~FileOutputStream();
+  ~FileOutputStream() override;
 
   /**
    * Get file.

src/oatpp/core/provider/Pool.hpp

@@ -365,7 +365,7 @@ public:
     return ptr;
   }
 
-  virtual ~PoolTemplate() {
+  virtual ~PoolTemplate() override {
     stop();
   }
 

src/oatpp/network/tcp/Connection.hpp

@@ -52,7 +52,7 @@ public:
    * Virtual Destructor (See &id:oatpp::base::Countable;).
    * Close socket handle.
    */
-  ~Connection();
+  ~Connection() override;
 
   /**
    * Implementation of &id:oatpp::data::stream::IOStream::write;.

src/oatpp/network/tcp/client/ConnectionProvider.cpp

@@ -184,7 +184,7 @@ oatpp::async::CoroutineStarterForResult<const provider::ResourceHandle<data::str
       , m_isHandleOpened(false)
     {}
 
-    ~ConnectCoroutine() {
+    ~ConnectCoroutine() override {
       if(m_result != nullptr) {
         freeaddrinfo(m_result);
       }

src/oatpp/network/tcp/server/ConnectionProvider.hpp

@@ -121,7 +121,7 @@ public:
   /**
    * Virtual destructor.
    */
-  ~ConnectionProvider();
+  ~ConnectionProvider() override;
 
   /**
    * Close accept-socket.

src/oatpp/network/virtual_/Socket.hpp

@@ -58,7 +58,7 @@ public:
   /**
    * Virtual destructor. Close corresponding pipes.
    */
-  ~Socket();
+  ~Socket() override;
 
   /**
    * Limit the available amount of bytes to read from socket and limit the available amount of bytes to write to socket. <br>

test/oatpp/core/data/buffer/ProcessorTest.cpp

@@ -161,7 +161,7 @@ public:
     COUNTER ++;
   }
 
-  ~TestCoroutine() {
+  ~TestCoroutine() override {
     COUNTER --;
   }