zhuyijun/gitea
1
0
Fork 0
forked from mirrors/gitea
Code Pull Requests Activity
815d267c80
gitea/models/fixtures
History
CaiCandong 815d267c80
Fix verifyCommits error when push a new branch (#26664) 
> ### Description
> If a new branch is pushed, and the repository has a rule that would
require signed commits for the new branch, the commit is rejected with a
500 error regardless of whether it's signed.
> 
> When pushing a new branch, the "old" commit is the empty ID
(0000000000000000000000000000000000000000). verifyCommits has no
provision for this and passes an invalid commit range to git rev-list.
Prior to 1.19 this wasn't an issue because only pre-existing individual
branches could be protected.
> 
> I was able to reproduce with
[try.gitea.io/CraigTest/test](https://try.gitea.io/CraigTest/test),
which is set up with a blanket rule to require commits on all branches.


Fix #25565
Very thanks to @Craig-Holmquist-NTI for reporting the bug and suggesting
an valid solution!

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-08-30 02:27:53 +00:00
..
access_token.yml Implement actions artifacts (#22738) 2023-05-19 21:37:57 +08:00
access.yml Fix user visible check (#21210) 2022-09-20 15:59:20 +08:00
action_run_job.yml Implement actions artifacts (#22738) 2023-05-19 21:37:57 +08:00
action_run.yml Implement actions artifacts (#22738) 2023-05-19 21:37:57 +08:00
action_task.yml Implement actions artifacts (#22738) 2023-05-19 21:37:57 +08:00
action.yml Support "." char as user name for User/Orgs in RSS/ATOM/GPG/KEYS path ... (#23874) 2023-04-07 18:08:36 +08:00
attachment.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
branch.yml Sync branches into databases (#22743) 2023-06-29 10:03:20 +00:00
collaboration.yml
comment.yml
commit_status_index.yml Fix commit status index problem (#17061) 2021-09-23 18:50:06 +08:00
commit_status.yml
deploy_key.yml
email_address.yml Fix verifyCommits error when push a new branch (#26664) 2023-08-30 02:27:53 +00:00
external_login_user.yml add test coverage for original author conversion during migrations (#18506) 2022-02-01 13:20:28 -05:00
follow.yml Fix user visible check (#21210) 2022-09-20 15:59:20 +08:00
gpg_key_import.yml
gpg_key.yml Fix verifyCommits error when push a new branch (#26664) 2023-08-30 02:27:53 +00:00
hook_task.yml Decouple HookTask from Repository (#17940) 2022-10-21 18:21:56 +02:00
issue_assignees.yml Fix issue overview for teams (#19652) 2022-05-16 17:49:17 +08:00
issue_index.yml Fix issue overview for teams (#19652) 2022-05-16 17:49:17 +08:00
issue_label.yml
issue_user.yml
issue_watch.yml
issue.yml Add commits dropdown in PR files view and allow commit by commit review (#25528) 2023-07-28 21:18:12 +02:00
label.yml Allow to archive labels (#26478) 2023-08-14 11:56:14 +02:00
lfs_meta_object.yml Test views of LFS files (#22196) 2022-12-23 07:41:56 +08:00
login_source.yml
milestone.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
mirror.yml Fix bug of branches API with tests (#25578) 2023-07-01 10:52:52 +08:00
notice.yml
notification.yml
oauth2_application.yml Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
oauth2_authorization_code.yml Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
oauth2_grant.yml Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
org_user.yml Revert package access change from #23879 (#25707) 2023-07-09 13:00:07 +00:00
project_board.yml Support org/user level projects (#22235) 2023-01-20 19:42:33 +08:00
project_issue.yml
project.yml Fix incorrect oldest sort in project list (#25806) 2023-07-11 20:47:50 +02:00
protected_branch.yml
public_key.yml
pull_request.yml Add commits dropdown in PR files view and allow commit by commit review (#25528) 2023-07-28 21:18:12 +02:00
reaction.yml
release.yml fix: release page for empty or non-existing target (#24470) 2023-05-10 11:43:55 +08:00
renamed_branch.yml Add a simple way to rename branch like gh (#15870) 2021-10-08 19:03:04 +02:00
repo_archiver.yml
repo_indexer_status.yml
repo_redirect.yml
repo_topic.yml
repo_transfer.yml
repo_unit.yml fix generated source URL on rendered files (#26364) 2023-08-08 09:04:04 +00:00
repository.yml Add commits dropdown in PR files view and allow commit by commit review (#25528) 2023-07-28 21:18:12 +02:00
review.yml Fix duplicate Reviewed-by trailers (#24796) 2023-06-09 16:34:49 +02:00
star.yml
stopwatch.yml
system_setting.yml Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
team_repo.yml
team_unit.yml Fix access check for org-level project (#26182) 2023-07-29 14:13:24 +00:00
team_user.yml Revert package access change from #23879 (#25707) 2023-07-09 13:00:07 +00:00
team.yml Revert package access change from #23879 (#25707) 2023-07-09 13:00:07 +00:00
topic.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
tracked_time.yml
two_factor.yml
user_open_id.yml
user_redirect.yml
user.yml Fix verifyCommits error when push a new branch (#26664) 2023-08-30 02:27:53 +00:00
watch.yml
webauthn_credential.yml Add some api integration tests (#18872) 2022-10-18 00:23:27 +08:00
webhook.yml Add user webhooks (#21563) 2023-03-10 08:28:32 -06:00