zhuyijun/nacos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ISSUE #5927] Init health check status when loading snapshot of persistent instances. (#5928)

Browse Source
This commit is contained in:
Pixy Yuan 2021-06-03 09:35:01 +08:00 committed by GitHub
parent 9ab1d62a06
commit 07f38a4763
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
naming/src/main/java/com/alibaba/nacos/naming/core/v2/client/impl/IpPortBasedClient.java
View File

@ -112,15 +112,17 @@ public class IpPortBasedClient extends AbstractClient {
} }
private HealthCheckInstancePublishInfo parseToHealthCheckInstance(InstancePublishInfo instancePublishInfo) { private HealthCheckInstancePublishInfo parseToHealthCheckInstance(InstancePublishInfo instancePublishInfo) {
HealthCheckInstancePublishInfo result;
if (instancePublishInfo instanceof HealthCheckInstancePublishInfo) { if (instancePublishInfo instanceof HealthCheckInstancePublishInfo) {
return (HealthCheckInstancePublishInfo) instancePublishInfo; result = (HealthCheckInstancePublishInfo) instancePublishInfo;
} } else {
HealthCheckInstancePublishInfo result = new HealthCheckInstancePublishInfo(); result = new HealthCheckInstancePublishInfo();
result.setIp(instancePublishInfo.getIp()); result.setIp(instancePublishInfo.getIp());
result.setPort(instancePublishInfo.getPort()); result.setPort(instancePublishInfo.getPort());
result.setHealthy(instancePublishInfo.isHealthy()); result.setHealthy(instancePublishInfo.isHealthy());
result.setCluster(instancePublishInfo.getCluster()); result.setCluster(instancePublishInfo.getCluster());
result.setExtendDatum(instancePublishInfo.getExtendDatum()); result.setExtendDatum(instancePublishInfo.getExtendDatum());
}
if (!ephemeral) { if (!ephemeral) {
result.initHealthCheck(); result.initHealthCheck();
} }

4
naming/src/main/java/com/alibaba/nacos/naming/healthcheck/v2/HealthCheckTaskV2.java
View File

@ -98,12 +98,12 @@ public class HealthCheckTaskV2 extends AbstractExecuteTask implements NacosHealt
ClusterMetadata metadata = getClusterMetadata(each, instancePublishInfo); ClusterMetadata metadata = getClusterMetadata(each, instancePublishInfo);
ApplicationUtils.getBean(HealthCheckProcessorV2Delegate.class).process(this, each, metadata); ApplicationUtils.getBean(HealthCheckProcessorV2Delegate.class).process(this, each, metadata);
if (Loggers.EVT_LOG.isDebugEnabled()) { if (Loggers.EVT_LOG.isDebugEnabled()) {
Loggers.EVT_LOG.debug("[HEALTH-CHECK] schedule health check task: {}", client.getClientId()); Loggers.EVT_LOG.debug("[HEALTH-CHECK-V2] schedule health check task: {}", client.getClientId());
} }
} }
} }
} catch (Throwable e) { } catch (Throwable e) {
Loggers.SRV_LOG.error("[HEALTH-CHECK] error while process health check for {}", client.getClientId(), e); Loggers.SRV_LOG.error("[HEALTH-CHECK-V2] error while process health check for {}", client.getClientId(), e);
} finally { } finally {
if (!cancelled) { if (!cancelled) {
HealthCheckReactor.scheduleCheck(this); HealthCheckReactor.scheduleCheck(this);

4
naming/src/main/java/com/alibaba/nacos/naming/healthcheck/v2/processor/TcpHealthCheckProcessor.java
View File

@ -101,7 +101,7 @@ public class TcpHealthCheckProcessor implements HealthCheckProcessorV2, Runnable
} }
// TODO handle marked(white list) logic like v1.x. // TODO handle marked(white list) logic like v1.x.
if (!instance.tryStartCheck()) { if (!instance.tryStartCheck()) {
SRV_LOG.warn("tcp check started before last one finished, service: {} : {} : {}:{}", SRV_LOG.warn("[HEALTH-CHECK-V2] tcp check started before last one finished, service: {} : {} : {}:{}",
service.getGroupedServiceName(), instance.getCluster(), instance.getIp(), instance.getPort()); service.getGroupedServiceName(), instance.getCluster(), instance.getIp(), instance.getPort());
healthCheckCommon healthCheckCommon
.reEvaluateCheckRT(task.getCheckRtNormalized() * 2, task, switchDomain.getTcpHealthParams()); .reEvaluateCheckRT(task.getCheckRtNormalized() * 2, task, switchDomain.getTcpHealthParams());
@ -151,7 +151,7 @@ public class TcpHealthCheckProcessor implements HealthCheckProcessorV2, Runnable
GlobalExecutor.executeTcpSuperSense(new PostProcessor(key)); GlobalExecutor.executeTcpSuperSense(new PostProcessor(key));
} }
} catch (Throwable e) { } catch (Throwable e) {
SRV_LOG.error("[HEALTH-CHECK] error while processing NIO task", e); SRV_LOG.error("[HEALTH-CHECK-V2] error while processing NIO task", e);
} }
} }
} }