From 1d3f1bb49228639320e2da659b7babca39998d1f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=A2=81=E5=A4=A9=E8=AF=AD?= <124244236@qq.com> Date: Tue, 20 Feb 2024 14:07:58 +0800 Subject: [PATCH] [ISSUE #11718] Fix ErrorCode have the same code (#11747) * [ISSUE #11718] Fix ErrorCode have the same code * Fix code style. --- .../alibaba/nacos/api/model/v2/ErrorCode.java | 2 +- .../nacos/api/model/v2/ErrorCodeTest.java | 40 +++++++++++++++++++ 2 files changed, 41 insertions(+), 1 deletion(-) create mode 100644 api/src/test/java/com/alibaba/nacos/api/model/v2/ErrorCodeTest.java diff --git a/api/src/main/java/com/alibaba/nacos/api/model/v2/ErrorCode.java b/api/src/main/java/com/alibaba/nacos/api/model/v2/ErrorCode.java index b86897c11..53b4c3573 100644 --- a/api/src/main/java/com/alibaba/nacos/api/model/v2/ErrorCode.java +++ b/api/src/main/java/com/alibaba/nacos/api/model/v2/ErrorCode.java @@ -178,7 +178,7 @@ public enum ErrorCode { /** * node down failure. */ - NODE_DOWN_FAILURE(23001, "node down failure"), + NODE_DOWN_FAILURE(23002, "node down failure"), /** * server error. diff --git a/api/src/test/java/com/alibaba/nacos/api/model/v2/ErrorCodeTest.java b/api/src/test/java/com/alibaba/nacos/api/model/v2/ErrorCodeTest.java new file mode 100644 index 000000000..3c6188113 --- /dev/null +++ b/api/src/test/java/com/alibaba/nacos/api/model/v2/ErrorCodeTest.java @@ -0,0 +1,40 @@ +/* + * Copyright 1999-2021 Alibaba Group Holding Ltd. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.alibaba.nacos.api.model.v2; + +import static org.junit.Assert.assertEquals; + +import java.util.HashSet; +import java.util.Set; + +import org.junit.Test; + +public class ErrorCodeTest { + @Test + public void testCodeNotSame() { + Class errorCodeClass = ErrorCode.class; + + ErrorCode[] errorCodes = errorCodeClass.getEnumConstants(); + Set codeSet = new HashSet(errorCodes.length); + + for (ErrorCode errorCode : errorCodes) { + codeSet.add(errorCode.getCode()); + } + + assertEquals(errorCodes.length, codeSet.size()); + } +}