zhuyijun/nacos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

groupName can't be empty. (#5196)

Browse Source
This commit is contained in:
赵延 2021-03-26 09:54:13 +08:00 committed by GitHub
parent 8cef69e502
commit 1ec21de8f4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
api/src/main/java/com/alibaba/nacos/api/naming/utils/NamingUtils.java
View File

@ -46,6 +46,9 @@ public class NamingUtils {
if (StringUtils.isBlank(serviceName)) { if (StringUtils.isBlank(serviceName)) {
throw new IllegalArgumentException("Param 'serviceName' is illegal, serviceName is blank"); throw new IllegalArgumentException("Param 'serviceName' is illegal, serviceName is blank");
} }
if (StringUtils.isBlank(groupName)) {
throw new IllegalArgumentException("Param 'groupName' is illegal, groupName is blank");
}
final String resultGroupedName = groupName + Constants.SERVICE_INFO_SPLITER + serviceName; final String resultGroupedName = groupName + Constants.SERVICE_INFO_SPLITER + serviceName;
return resultGroupedName.intern(); return resultGroupedName.intern();
} }
@ -75,7 +78,7 @@ public class NamingUtils {
* <pre> * <pre>
* serviceName = "@@"; the length = 0; illegal * serviceName = "@@"; the length = 0; illegal
* serviceName = "group@@"; the length = 1; illegal * serviceName = "group@@"; the length = 1; illegal
* serviceName = "@@serviceName"; the length = 2; legal * serviceName = "@@serviceName"; the length = 2; illegal
* serviceName = "group@@serviceName"; the length = 2; legal * serviceName = "group@@serviceName"; the length = 2; legal
* </pre> * </pre>
* *
@ -87,6 +90,9 @@ public class NamingUtils {
throw new IllegalArgumentException( throw new IllegalArgumentException(
"Param 'serviceName' is illegal, it should be format as 'groupName@@serviceName'"); "Param 'serviceName' is illegal, it should be format as 'groupName@@serviceName'");
} }
if (split[0].isEmpty()) {
throw new IllegalArgumentException("Param 'serviceName' is illegal, groupName can't be empty");
}
} }
/** /**