From 64b75ef3e11ff9979ed4d582355e1b75f6a25185 Mon Sep 17 00:00:00 2001 From: yangyshdan Date: Wed, 7 Nov 2018 23:00:26 +0800 Subject: [PATCH] Update CONTRIBUTING.md #166 --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 86f4eb233..e2d293cd1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -37,7 +37,7 @@ If you just want to contribute directly We use the `develop` branch as the development branch, which indicates that this is a unstable branch. -Here are the workflow for contributors: +Here is the workflow for contributors: 1. Fork to your own 2. Clone fork to local repository @@ -61,7 +61,7 @@ The final commit message should be clear and concise. ### Code review guidance -Our PMC will rotate reviewing the code to make sure all the PR will be reviewed timely and by at least one committer. If we aren't doing our job (sometimes we drop things). And as always, we welcome volunteers for code review. +Our PMC will rotate reviewing the code to make sure all the PR will be reviewed timely and by at least one committer before merge. If we aren't doing our job (sometimes we drop things). And as always, we welcome volunteers for code review. Some principles: