zhuyijun/nacos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ISSUE #9643] Fixed Possible JSON Ordering Permutations Problem in Tests (#9505)

Browse Source 
* Fixed Flaky Test

* Fix Updated
This commit is contained in:
Bharati Kulkarni 2022-11-16 21:40:36 -06:00 committed by GitHub
parent 4bd5b7c85a
commit 66c3899ecb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
common/src/test/java/com/alibaba/nacos/common/utils/JacksonUtilsTest.java
View File

@ -37,7 +37,7 @@ import java.math.BigDecimal;
import java.nio.charset.Charset;
import java.util.Collections;
import java.util.Date;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.atomic.AtomicBoolean;
@ -435,7 +435,7 @@ public class JacksonUtilsTest {
@Test
public void testToJsonBytes() {
Map<String, Object> map = new HashMap<String, Object>();
Map<String, Object> map = new LinkedHashMap<String, Object>();
map.put("string", "你好，中国！");
map.put("integer", 999);
RestResult<Map<String, Object>> restResult = new RestResult();
@ -443,9 +443,8 @@ public class JacksonUtilsTest {
byte[] bytes = JacksonUtils.toJsonBytes(restResult);
String jsonFromBytes = ByteUtils.toString(bytes);
String expectedJson = "{\"code\":0,\"data\":{\"string\":\"你好，中国！\",\"integer\":999}}";
Assert.assertEquals(expectedJson, jsonFromBytes);
Assert.assertTrue(jsonFromBytes.contains("\"code\":0"));
Assert.assertTrue(jsonFromBytes.contains("\"data\":{\"string\":\"你好，中国！\",\"integer\":999}"));
// old `toJsonBytes` method implementation:
// public static byte[] toJsonBytes(Object obj) {
// try {
@ -457,7 +456,9 @@ public class JacksonUtilsTest {
// here is a verification to compare with the old implementation
byte[] bytesFromOldImplementation = ByteUtils.toBytes(JacksonUtils.toJson(restResult));
Assert.assertEquals(expectedJson, new String(bytesFromOldImplementation, Charset.forName(Constants.ENCODE)));
String jsonFromBytesOldImplementation = new String(bytesFromOldImplementation, Charset.forName(Constants.ENCODE));
Assert.assertTrue(jsonFromBytesOldImplementation.contains("\"code\":0"));
Assert.assertTrue(jsonFromBytesOldImplementation.contains("\"data\":{\"string\":\"你好，中国！\",\"integer\":999}"));
}
@Test