zhuyijun/nacos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ISSUE #8709] check serverList size before reconnect to server (#8710)

Browse Source 
* [ISSUE #8709] check serverList size before reconnect to server

* use CollectionUtils.isEmpty to judge whether server list  is empty

Co-authored-by: Oliver <wqdyxnbd@163.com>

Co-authored-by: Oliver <wqdyxnbd@163.com>
This commit is contained in:
MajorHe1 2022-07-08 11:52:11 +08:00 committed by GitHub
parent 7bb1e90549
commit 68b521679c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/src/main/java/com/alibaba/nacos/client/auth/impl/process/HttpLoginProcessor.java
View File

@ -91,7 +91,7 @@ public class HttpLoginProcessor implements LoginProcessor {
}
return loginIdentityContext;
} catch (Exception e) {
SECURITY_LOGGER.error("[ NacosClientAuthServiceImpl] login http request failed"
SECURITY_LOGGER.error("[NacosClientAuthServiceImpl] login http request failed"
+ " url: {}, params: {}, bodyMap: {}, errorMsg: {}", url, params, bodyMap, e.getMessage());
return null;
}

2
client/src/main/java/com/alibaba/nacos/client/config/impl/ClientWorker.java
View File

@ -665,7 +665,7 @@ public class ClientWorker implements Closeable {
@Override
public List<String> getServerList() {
return ConfigRpcTransportClient.super.serverListManager.serverUrls;
return ConfigRpcTransportClient.super.serverListManager.getServerUrls();
}
});

4
common/src/main/java/com/alibaba/nacos/common/remote/client/RpcClient.java
View File

@ -551,6 +551,10 @@ public abstract class RpcClient implements Closeable {
recommendServer.set(null);
}
if (CollectionUtils.isEmpty(RpcClient.this.serverListFactory.getServerList())) {
throw new Exception("server list is empty");
}
if (reConnectTimes > 0
&& reConnectTimes % RpcClient.this.serverListFactory.getServerList().size() == 0) {
LoggerUtils.printIfInfoEnabled(LOGGER,