zhuyijun/nacos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PageHandlerAdapterFactory， handlerAdapters，handlerAdapterMap should unmodifiable (#11801)

Browse Source 
* Update LocalSimpleCountRateCounter.java

fixbug

* Update LocalSimpleCountRateCounter.java

bugfix

* fix：默认的nacos反脆弱插件的问题

* fix：默认的nacos反脆弱插件的问题

* fix：默认的nacos反脆弱插件的问题

* fix：默认的nacos反脆弱插件的问题

* fix：默认的nacos反脆弱插件的问题,调整为tryAdd

* fix：默认的nacos反脆弱插件的问题,调整为tryAdd

* 调整测试方式，保障流水线成功

* 重构PageHandlerAdapterFactory,这里将handlerAdapters，handlerAdapterMap设置为unmodifiable

* 重构PageHandlerAdapterFactory,这里将handlerAdapters，handlerAdapterMap设置为unmodifiable
This commit is contained in:
温安适 2024-03-07 10:48:49 +08:00 committed by GitHub
parent b7c3905976
commit c2aa515f1e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 28 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

65
plugin-default-impl/nacos-default-auth-plugin/src/main/java/com/alibaba/nacos/plugin/auth/impl/persistence/handler/PageHandlerAdapterFactory.java
View File

@ -24,6 +24,8 @@ import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Collections;
import java.util.function.Consumer;
/**
* pagination factory.
@ -31,54 +33,43 @@ import java.util.Map;
* @author huangKeMing
*/
public class PageHandlerAdapterFactory {
private static PageHandlerAdapterFactory instance;
private List<PageHandlerAdapter> handlerAdapters;
private Map<String, PageHandlerAdapter> handlerAdapterMap;
private final List<PageHandlerAdapter> handlerAdapters;
private final Map<String, PageHandlerAdapter> handlerAdapterMap;
public List<PageHandlerAdapter> getHandlerAdapters() {
return handlerAdapters;
}
public Map<String, PageHandlerAdapter> getHandlerAdapterMap() {
return handlerAdapterMap;
}
private PageHandlerAdapterFactory() {
handlerAdapters = new ArrayList<>(3);
handlerAdapterMap = new HashMap<>(3);
initHandlerAdapters();
}
public static PageHandlerAdapterFactory getInstance() {
if (instance == null) {
synchronized (PageHandlerAdapterFactory.class) {
if (instance == null) {
instance = new PageHandlerAdapterFactory();
}
}
}
return instance;
}
/**
* init handler adapters.
*/
private void initHandlerAdapters() {
List<PageHandlerAdapter> handlerAdapters = new ArrayList<>(3);
Map<String, PageHandlerAdapter> handlerAdapterMap = new HashMap<>(3);
Consumer<PageHandlerAdapter> addHandlerAdapter = handlerAdapter -> {
handlerAdapters.add(handlerAdapter);
handlerAdapterMap.put(handlerAdapter.getClass().getName(), handlerAdapter);
};
// MysqlPageHandlerAdapter
addHandlerAdapter(new MysqlPageHandlerAdapter());
addHandlerAdapter.accept(new MysqlPageHandlerAdapter());
// DerbyPageHandlerAdapter
addHandlerAdapter(new DerbyPageHandlerAdapter());
addHandlerAdapter.accept(new DerbyPageHandlerAdapter());
// DefaultPageHandlerAdapter
addHandlerAdapter(new DefaultPageHandlerAdapter());
addHandlerAdapter.accept(new DefaultPageHandlerAdapter());
this.handlerAdapters = Collections.unmodifiableList(handlerAdapters);
this.handlerAdapterMap = Collections.unmodifiableMap(handlerAdapterMap);
}
private void addHandlerAdapter(PageHandlerAdapter handlerAdapter) {
handlerAdapters.add(handlerAdapter);
handlerAdapterMap.put(handlerAdapter.getClass().getName(), handlerAdapter);
private static final class InstanceHolder {
static final PageHandlerAdapterFactory INSTANCE = new PageHandlerAdapterFactory();
}
public static PageHandlerAdapterFactory getInstance() {
return InstanceHolder.INSTANCE;
}
}