diff --git a/test/core-test/src/test/java/com/alibaba/nacos/test/core/SnowFlowerIdGenerator_ITCase.java b/test/core-test/src/test/java/com/alibaba/nacos/test/core/SnowFlowerIdGeneratorCoreITCase.java similarity index 85% rename from test/core-test/src/test/java/com/alibaba/nacos/test/core/SnowFlowerIdGenerator_ITCase.java rename to test/core-test/src/test/java/com/alibaba/nacos/test/core/SnowFlowerIdGeneratorCoreITCase.java index f977e1bba..3929192d2 100644 --- a/test/core-test/src/test/java/com/alibaba/nacos/test/core/SnowFlowerIdGenerator_ITCase.java +++ b/test/core-test/src/test/java/com/alibaba/nacos/test/core/SnowFlowerIdGeneratorCoreITCase.java @@ -24,12 +24,16 @@ import org.springframework.core.env.StandardEnvironment; import static org.junit.jupiter.api.Assertions.assertNotEquals; /** + * Integration test case for validating unique ID generation using SnowFlowerIdGenerator with distinct initializations + * and assertions for uniqueness. + * * @author liaochuntao */ -class SnowFlowerIdGenerator_ITCase { +@SuppressWarnings("checkstyle:AbbreviationAsWordInName") +class SnowFlowerIdGeneratorCoreITCase { @Test - void test_idGenerator() { + void testIdGenerator() { EnvUtil.setEnvironment(new StandardEnvironment()); SnowFlowerIdGenerator generator1 = new SnowFlowerIdGenerator(); SnowFlowerIdGenerator generator2 = new SnowFlowerIdGenerator(); diff --git a/test/core-test/src/test/java/com/alibaba/nacos/test/core/cluster/MemberLookup_ITCase.java b/test/core-test/src/test/java/com/alibaba/nacos/test/core/cluster/MemberLookupCoreITCase.java similarity index 84% rename from test/core-test/src/test/java/com/alibaba/nacos/test/core/cluster/MemberLookup_ITCase.java rename to test/core-test/src/test/java/com/alibaba/nacos/test/core/cluster/MemberLookupCoreITCase.java index 2145ed40c..8622d5812 100644 --- a/test/core-test/src/test/java/com/alibaba/nacos/test/core/cluster/MemberLookup_ITCase.java +++ b/test/core-test/src/test/java/com/alibaba/nacos/test/core/cluster/MemberLookupCoreITCase.java @@ -43,17 +43,22 @@ import java.util.Arrays; import java.util.Map; import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertInstanceOf; import static org.junit.jupiter.api.Assertions.assertTrue; /** + * Integration test case for Member Lookup functionality, validating different lookup strategies: file configuration, + * standalone mode, and address server lookup. + * * @author liaochuntao */ +@SuppressWarnings("checkstyle:AbbreviationAsWordInName") @TestMethodOrder(MethodName.class) -class MemberLookup_ITCase { +class MemberLookupCoreITCase { - static final String path = Paths.get(System.getProperty("user.home"), "/member_look").toString(); + private final String path = Paths.get(System.getProperty("user.home"), "/member_look").toString(); - static final String name = "cluster.conf"; + private final String name = "cluster.conf"; ServerMemberManager memberManager; @@ -70,7 +75,8 @@ class MemberLookup_ITCase { File file = Paths.get(path, "conf", name).toFile(); DiskUtils.touch(file); String ip = InetUtils.getSelfIP(); - DiskUtils.writeFile(file, (ip + ":8848," + ip + ":8847," + ip + ":8849").getBytes(StandardCharsets.UTF_8), false); + DiskUtils.writeFile(file, (ip + ":8848," + ip + ":8847," + ip + ":8849").getBytes(StandardCharsets.UTF_8), + false); try { memberManager = new ServerMemberManager(new MockServletContext()); @@ -90,19 +96,19 @@ class MemberLookup_ITCase { } @Test - void test_a_lookup_file_config() throws Exception { + void testLookupFileConfig() throws Exception { try { LookupFactory.createLookUp(memberManager); } catch (Throwable ignore) { } MemberLookup lookup = LookupFactory.getLookUp(); System.out.println(lookup); - assertTrue(lookup instanceof FileConfigMemberLookup); + assertInstanceOf(FileConfigMemberLookup.class, lookup); func(lookup); } @Test - void test_b_lookup_standalone() throws Exception { + void testLookupStandalone() throws Exception { EnvUtil.setIsStandalone(true); try { LookupFactory.createLookUp(memberManager); @@ -113,11 +119,11 @@ class MemberLookup_ITCase { } MemberLookup lookup = LookupFactory.getLookUp(); System.out.println(lookup); - assertTrue(lookup instanceof StandaloneMemberLookup); + assertInstanceOf(StandaloneMemberLookup.class, lookup); } @Test - void test_c_lookup_address_server() throws Exception { + void testLookupAddressServer() throws Exception { EnvUtil.setIsStandalone(false); System.out.println(EnvUtil.getClusterConfFilePath()); DiskUtils.deleteFile(Paths.get(path, "conf").toString(), "cluster.conf"); @@ -128,7 +134,7 @@ class MemberLookup_ITCase { } MemberLookup lookup = LookupFactory.getLookUp(); System.out.println(lookup); - assertTrue(lookup instanceof AddressServerMemberLookup); + assertInstanceOf(AddressServerMemberLookup.class, lookup); try { func(lookup); } catch (NacosException e) { diff --git a/test/core-test/src/test/java/com/alibaba/nacos/test/core/cluster/ServerMemberManager_ITCase.java b/test/core-test/src/test/java/com/alibaba/nacos/test/core/cluster/ServerMemberManagerCoreITCase.java similarity index 96% rename from test/core-test/src/test/java/com/alibaba/nacos/test/core/cluster/ServerMemberManager_ITCase.java rename to test/core-test/src/test/java/com/alibaba/nacos/test/core/cluster/ServerMemberManagerCoreITCase.java index 53dc85b4a..8a13bb29a 100644 --- a/test/core-test/src/test/java/com/alibaba/nacos/test/core/cluster/ServerMemberManager_ITCase.java +++ b/test/core-test/src/test/java/com/alibaba/nacos/test/core/cluster/ServerMemberManagerCoreITCase.java @@ -57,9 +57,10 @@ import static org.junit.jupiter.api.Assertions.assertTrue; * * @author liaochuntao */ +// todo fix +@SuppressWarnings("checkstyle:AbbreviationAsWordInName") @TestMethodOrder(MethodName.class) - // todo fix -class ServerMemberManager_ITCase { +class ServerMemberManagerCoreITCase { private ServerMemberManager memberManager; @@ -148,7 +149,8 @@ class ServerMemberManager_ITCase { @Override public void onEvent(MembersChangeEvent event) { System.out.println(event); - healthMembers.set(MemberUtil.selectTargetMembers(event.getMembers(), member -> !NodeState.DOWN.equals(member.getState()))); + healthMembers.set(MemberUtil.selectTargetMembers(event.getMembers(), + member -> !NodeState.DOWN.equals(member.getState()))); if (first.getCount() == 1) { first.countDown(); return; @@ -186,7 +188,7 @@ class ServerMemberManager_ITCase { member.setState(NodeState.DOWN); assertTrue(memberManager.update(member)); - second.await();//fix blocking + second.await(); //fix blocking copy = new HashSet<>(firstMemberList); copy.removeAll(healthMembers.get()); assertEquals(3, copy.size()); diff --git a/test/core-test/src/test/java/com/alibaba/nacos/test/core/code/ControllerMethodsCache_ITCase.java b/test/core-test/src/test/java/com/alibaba/nacos/test/core/code/ControllerMethodsCacheCoreITCase.java similarity index 93% rename from test/core-test/src/test/java/com/alibaba/nacos/test/core/code/ControllerMethodsCache_ITCase.java rename to test/core-test/src/test/java/com/alibaba/nacos/test/core/code/ControllerMethodsCacheCoreITCase.java index 738e235c8..64f8e167c 100644 --- a/test/core-test/src/test/java/com/alibaba/nacos/test/core/code/ControllerMethodsCache_ITCase.java +++ b/test/core-test/src/test/java/com/alibaba/nacos/test/core/code/ControllerMethodsCacheCoreITCase.java @@ -31,10 +31,14 @@ import java.util.Map; import static org.junit.jupiter.api.Assertions.assertEquals; /** + * Integration test case for validating ControllerMethodsCache functionality,ensuring correct method retrieval based on + * different request parameters. + * * @author horizonzy * @since 1.3.2 */ -class ControllerMethodsCache_ITCase { +@SuppressWarnings("checkstyle:AbbreviationAsWordInName") +class ControllerMethodsCacheCoreITCase { private ControllerMethodsCache methodsCache; diff --git a/test/core-test/src/test/java/com/alibaba/nacos/test/smoke/nacosSmoke_ITCase.java b/test/core-test/src/test/java/com/alibaba/nacos/test/smoke/NacosSmokeCoreITCase.java similarity index 86% rename from test/core-test/src/test/java/com/alibaba/nacos/test/smoke/nacosSmoke_ITCase.java rename to test/core-test/src/test/java/com/alibaba/nacos/test/smoke/NacosSmokeCoreITCase.java index b1b7a23b4..1b55a1d96 100644 --- a/test/core-test/src/test/java/com/alibaba/nacos/test/smoke/nacosSmoke_ITCase.java +++ b/test/core-test/src/test/java/com/alibaba/nacos/test/smoke/NacosSmokeCoreITCase.java @@ -21,9 +21,10 @@ import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -class nacosSmoke_ITCase { +@SuppressWarnings("checkstyle:AbbreviationAsWordInName") +class NacosSmokeCoreITCase { - private static Logger logger = Logger.getLogger(nacosSmoke_ITCase.class); + private static Logger logger = Logger.getLogger(NacosSmokeCoreITCase.class); @BeforeEach void setUp() {