zhuyijun/nacos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

For pmd

Browse Source
This commit is contained in:
KomachiSion 2023-05-12 10:14:21 +08:00
parent 5897a61e8e
commit dc79f05838
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
config/src/main/java/com/alibaba/nacos/config/server/aspect/ConfigChangeAspect.java
View File

@ -287,7 +287,8 @@ public class ConfigChangeAspect {
configChangeRequest.setArg("modifyTime", TimeUtils.getCurrentTimeStr()); configChangeRequest.setArg("modifyTime", TimeUtils.getCurrentTimeStr());
ConfigChangePointCutTypes handleType = configChangeRequest.getRequestType(); ConfigChangePointCutTypes handleType = configChangeRequest.getRequestType();
ConfigChangeResponse configChangeResponse = new ConfigChangeResponse(handleType); ConfigChangeResponse configChangeResponse = new ConfigChangeResponse(handleType);
configChangeResponse.setSuccess(true); // default success,when before plugin service verify failed , set false // default success,when before plugin service verify failed , set false
configChangeResponse.setSuccess(true);
PriorityQueue<ConfigChangePluginService> beforeExecutePriorityQueue = new PriorityQueue<>( PriorityQueue<ConfigChangePluginService> beforeExecutePriorityQueue = new PriorityQueue<>(
DEFAULT_BEFORE_QUEUE_CAPACITY, Comparator.comparingInt(ConfigChangePluginService::getOrder)); DEFAULT_BEFORE_QUEUE_CAPACITY, Comparator.comparingInt(ConfigChangePluginService::getOrder));
PriorityQueue<ConfigChangePluginService> afterExecutePriorityQueue = new PriorityQueue<>( PriorityQueue<ConfigChangePluginService> afterExecutePriorityQueue = new PriorityQueue<>(
@ -315,7 +316,8 @@ public class ConfigChangeAspect {
configChangeRequest.setArg("pluginProperties", properties); configChangeRequest.setArg("pluginProperties", properties);
ccs.execute(configChangeRequest, configChangeResponse); ccs.execute(configChangeRequest, configChangeResponse);
if (null != configChangeResponse.getArgs()) { if (null != configChangeResponse.getArgs()) {
args = configChangeResponse.getArgs(); // update args by filter with whitelist // update args by filter with whitelist
args = configChangeResponse.getArgs();
} }
// prevent execute next before plugins service // prevent execute next before plugins service
if (!configChangeResponse.isSuccess()) { if (!configChangeResponse.isSuccess()) {
@ -325,7 +327,8 @@ public class ConfigChangeAspect {
} }
try { try {
if (configChangeResponse.isSuccess()) { // if validate failed,skipped directly // if validate failed,skipped directly
if (configChangeResponse.isSuccess()) {
retVal = pjp.proceed(args); retVal = pjp.proceed(args);
} }
} catch (Throwable e) { } catch (Throwable e) {