zhuyijun/nacos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ISSUE #5095] Add unit test for ClassUtils (#6327)

Browse Source 
* fix typo

* add unit test for ClassUtils
This commit is contained in:
孙继峰 2021-07-12 09:45:35 +08:00 committed by GitHub
parent 6f826e9a55
commit f326a0c543
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 57 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
common/src/main/java/com/alibaba/nacos/common/utils/ClassUtils.java
View File

@ -106,7 +106,7 @@ public final class ClassUtils {
* @param cls Instances of the class represent classes and interfaces.
* @return the simple name of the underlying class.
*/
public static String getSimplaName(Class cls) {
public static String getSimpleName(Class cls) {
Objects.requireNonNull(cls, "cls");
return cls.getSimpleName();
}
@ -117,7 +117,7 @@ public final class ClassUtils {
* @param obj Object instance.
* @return the simple name of the underlying class.
*/
public static String getSimplaName(Object obj) {
public static String getSimpleName(Object obj) {
Objects.requireNonNull(obj, "obj");
return obj.getClass().getSimpleName();
}

53
common/src/test/java/com/alibaba/nacos/common/utils/ClassUtilsTest.java Normal file
View File

@ -0,0 +1,53 @@
/*
* Copyright 1999-2018 Alibaba Group Holding Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.alibaba.nacos.common.utils;
import com.alibaba.nacos.api.exception.runtime.NacosRuntimeException;
import org.junit.Assert;
import org.junit.Test;
public class ClassUtilsTest {
@Test
public void testFindClassByName1() {
Class<?> clazz = ClassUtils.findClassByName("java.lang.Integer");
Assert.assertEquals("java.lang.Integer", clazz.getName());
}
@Test(expected = NacosRuntimeException.class)
public void testFindClassByName2() {
ClassUtils.findClassByName("not.exist.Class");
}
@Test
public void testGetName() {
final String name = "java.lang.Integer";
Integer val = 1;
Assert.assertEquals(name, ClassUtils.getName(val));
Assert.assertEquals(name, ClassUtils.getName(Integer.class));
Assert.assertEquals(name, ClassUtils.getCanonicalName(val));
Assert.assertEquals(name, ClassUtils.getCanonicalName(Integer.class));
Assert.assertEquals("Integer", ClassUtils.getSimpleName(val));
Assert.assertEquals("Integer", ClassUtils.getSimpleName(Integer.class));
}
@Test
public void testIsAssignableFrom() {
Assert.assertTrue(ClassUtils.isAssignableFrom(Object.class, Integer.class));
}
}

4
naming/src/main/java/com/alibaba/nacos/naming/core/v2/service/impl/PersistentClientOperationServiceImpl.java
View File

@ -240,9 +240,9 @@ public class PersistentClientOperationServiceImpl extends RequestProcessor4CP im
private class PersistentInstanceSnapshotOperation extends AbstractSnapshotOperation {
private final String snapshotSaveTag = ClassUtils.getSimplaName(getClass()) + ".SAVE";
private final String snapshotSaveTag = ClassUtils.getSimpleName(getClass()) + ".SAVE";
private final String snapshotLoadTag = ClassUtils.getSimplaName(getClass()) + ".LOAD";
private final String snapshotLoadTag = ClassUtils.getSimpleName(getClass()) + ".LOAD";
private static final String SNAPSHOT_ARCHIVE = "persistent_instance.zip";