From fb8255c8b7568f388023e9f21fc6ad9110d9614b Mon Sep 17 00:00:00 2001 From: MajorHe1 <53824889+MajorHe1@users.noreply.github.com> Date: Thu, 13 Apr 2023 19:14:45 +0800 Subject: [PATCH] [ISSUE #10310] Update log output in RpcConfigChangeNotifier.java when push fail (#10312) * [ISSUE #10310]Update log output in RpcConfigChangeNotifier.java when push fail Update log output in RpcConfigChangeNotifier.java when push fail * update indentation level update indentation level --- .../config/server/remote/RpcConfigChangeNotifier.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/config/src/main/java/com/alibaba/nacos/config/server/remote/RpcConfigChangeNotifier.java b/config/src/main/java/com/alibaba/nacos/config/server/remote/RpcConfigChangeNotifier.java index 56437f19d..c6f70262a 100644 --- a/config/src/main/java/com/alibaba/nacos/config/server/remote/RpcConfigChangeNotifier.java +++ b/config/src/main/java/com/alibaba/nacos/config/server/remote/RpcConfigChangeNotifier.java @@ -117,7 +117,7 @@ public class RpcConfigChangeNotifier extends Subscriber { push(rpcPushRetryTask); notifyClientCount++; } - Loggers.REMOTE_PUSH.info("push [{}] clients ,groupKey=[{}]", notifyClientCount, groupKey); + Loggers.REMOTE_PUSH.info("push [{}] clients, groupKey=[{}]", notifyClientCount, groupKey); } @Override @@ -191,7 +191,9 @@ public class RpcConfigChangeNotifier extends Subscriber { tpsCheckRequest.setPointName(POINT_CONFIG_PUSH_FAIL); tpsControlManager.check(tpsCheckRequest); - Loggers.REMOTE_PUSH.warn("Push fail", e); + Loggers.REMOTE_PUSH + .warn("Push fail, dataId={}, group={}, tenant={}, clientId={}", notifyRequest.getDataId(), + notifyRequest.getGroup(), notifyRequest.getTenant(), connectionId, e); push(RpcPushTask.this); } @@ -206,7 +208,7 @@ public class RpcConfigChangeNotifier extends Subscriber { ConfigChangeNotifyRequest notifyRequest = retryTask.notifyRequest; if (retryTask.isOverTimes()) { Loggers.REMOTE_PUSH - .warn("push callback retry fail over times .dataId={},group={},tenant={},clientId={},will unregister client.", + .warn("push callback retry fail over times. dataId={},group={},tenant={},clientId={}, will unregister client.", notifyRequest.getDataId(), notifyRequest.getGroup(), notifyRequest.getTenant(), retryTask.connectionId); connectionManager.unregister(retryTask.connectionId);