zhuyijun/nacos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update CONTRIBUTING.md

Browse Source 
#166
This commit is contained in:
yangyshdan 2018-11-07 23:00:26 +08:00 committed by GitHub
parent 1649378a4d
commit 64b75ef3e1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CONTRIBUTING.md
View File

@ -37,7 +37,7 @@ If you just want to contribute directly
We use the `develop` branch as the development branch, which indicates that this is a unstable branch. We use the `develop` branch as the development branch, which indicates that this is a unstable branch.
Here are the workflow for contributors: Here is the workflow for contributors:
1. Fork to your own 1. Fork to your own
2. Clone fork to local repository 2. Clone fork to local repository
@ -61,7 +61,7 @@ The final commit message should be clear and concise.
### Code review guidance ### Code review guidance
Our PMC will rotate reviewing the code to make sure all the PR will be reviewed timely and by at least one committer. If we aren't doing our job (sometimes we drop things). And as always, we welcome volunteers for code review. Our PMC will rotate reviewing the code to make sure all the PR will be reviewed timely and by at least one committer before merge. If we aren't doing our job (sometimes we drop things). And as always, we welcome volunteers for code review.
Some principles: Some principles: